New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: babel-eslint-parser passes through config options #11639
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c200084:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23146/ |
@kaicataldo thanks so much for this, it's really awesome to see this finally get implemented! If I still lived in Brooklyn (and if it weren't for covid) I'd buy you a beer. In the meantime is there a spot I can make a one off contribution towards your OSS work? |
@jharris4 Thanks for the kind words ❤️ I currently have a GitHub Sponsors profile, but it unfortunately doesn't allow for one time donations. Hit me up if you end up back in Brooklyn post-pandemic - would love to hang out! |
83e4ae6
to
8e3f0dd
Compare
Thanks for the reviews, all! |
As discussed in #11334, this PR allows for users to pass through Babel configuration options directly to Babel's parse method, allowing for
@babel/eslint-parser
to be used without a Babel configuration file.We already have a few tests that cover this code path (see here). I feel like this is sufficient for now, but please let me know if you would rather I added more test cases.
cc @jharris4